Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_admin function #933

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Add is_admin function #933

merged 4 commits into from
Jul 12, 2023

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Jul 6, 2023

What

Resolves #635.

@sisuresh sisuresh requested a review from graydon as a code owner July 6, 2023 21:27
@sisuresh
Copy link
Contributor Author

sisuresh commented Jul 6, 2023

@tamirms This just adds an is_admin function, and we'll add it to the admin interface in the sdk. I didn't add a method for the issuer since like you mentioned it already exists as a subset of name, and I think that's sufficient for now. What do you think?

@sisuresh sisuresh requested review from tamirms and dmkozh July 12, 2023 00:18
@sisuresh sisuresh enabled auto-merge (squash) July 12, 2023 20:04
@sisuresh sisuresh merged commit 48cfc0f into stellar:main Jul 12, 2023
8 checks passed
@sisuresh sisuresh mentioned this pull request Jul 12, 2023
Merged
sisuresh added a commit to stellar/rs-soroban-sdk that referenced this pull request Jul 26, 2023
@sisuresh
Add admin function (#1038)
0a95f57 
Match stellar/rs-soroban-env#933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms tamirms approved these changes

@dmkozh dmkozh dmkozh approved these changes

@graydon graydon Awaiting requested review from graydon graydon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stellar Asset Contract missing admin() and issuer() functions
3 participants
@sisuresh @tamirms @dmkozh